Skip to content

Conversation

nbbeeken
Copy link
Contributor

Description

What is changing?

Remove skip on node versions greater than 19

Is there new documentation needed for these changes?

No

What is the motivation for this change?

More coverage

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken force-pushed the unskip-kmip-case4-should-fail-with-no-tls branch from baefc93 to 7e413a5 Compare August 28, 2024 19:12
@nbbeeken nbbeeken force-pushed the unskip-kmip-case4-should-fail-with-no-tls branch from 7e413a5 to 27a611f Compare August 29, 2024 15:07
@nbbeeken nbbeeken marked this pull request as ready for review August 29, 2024 15:49
@baileympearson baileympearson self-assigned this Aug 29, 2024
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Aug 29, 2024
@baileympearson baileympearson self-requested a review August 29, 2024 16:33
@baileympearson baileympearson merged commit 1f10bdf into main Aug 29, 2024
3 checks passed
@baileympearson baileympearson deleted the unskip-kmip-case4-should-fail-with-no-tls branch August 29, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants